Require Applicative (g s) as a superclass of FieldGrammar by Bodigrim · Pull Request #11821 · haskell/cabal

Bodigrim · 2026-05-12T23:55:51Z

I think we can finally act on the old TODO, cutting a bit of boilerplate.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

Patches conform to the coding conventions.
Any changes that could be relevant to users have been recorded in the changelog.
- Is the change significant? If so, remember to add significance: significant in the changelog file.
The documentation has been updated, if necessary.
Manual QA notes have been included.
Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

Thus acting on the old todo, which helps a little bit with boilerplate.

ulysses4ever approved these changes May 13, 2026

View reviewed changes

leana8959 reviewed May 13, 2026

View reviewed changes

Comment thread Cabal-syntax/src/Distribution/FieldGrammar/Class.hs

philderbeast approved these changes May 14, 2026

View reviewed changes

Require Applicative (g s) as a superclass of FieldGrammar

cbfdc42

Thus acting on the old todo, which helps a little bit with boilerplate.

Bodigrim force-pushed the require-applicative-for-FieldGrammar branch from 17840c4 to cbfdc42 Compare May 14, 2026 21:19

Bodigrim added the merge me Tell Mergify Bot to merge label May 14, 2026

mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label May 14, 2026

Provide feedback